linux-kernel - Re: [net-next] tg3: allow ethtool -p to work for NICs in down state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACKFLi=kJ3FLuXFchVQ2mf0K09E7y5iVJNBTPsFZiv3Zaafitw@mail.gmail.com>
Date:   Mon, 1 Apr 2019 22:22:01 -0700
From:   Michael Chan <michael.chan@...adcom.com>
To:     Jon Maxwell <jmaxwell37@...il.com>
Cc:     David Miller <davem@...emloft.net>,
        Siva Reddy Kallam <siva.kallam@...adcom.com>,
        "prashant.sreedharan@...adcom.com" <prashant@...adcom.com>,
        "michael.chan@...adcom.com" <mchan@...adcom.com>,
        Netdev <netdev@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>, jmaxwell@...hat.com
Subject: Re: [net-next] tg3: allow ethtool -p to work for NICs in down state

On Mon, Apr 1, 2019 at 10:09 PM Jon Maxwell <jmaxwell37@...il.com> wrote:
>
> Make tg3 behave like other drivers and let "ethtool -p" identify the
> NIC even when it's in the DOWN state. Before this patch it would get an
> error as follows if the NIC was down:
>
> # ip link set down dev em4
> # ethtool -p em4
> Cannot identify NIC: Resource temporarily unavailable
>
> With this patch ethtool identify works regardless of whether the NIC is up
> or down as it does for other drivers.
>
> Signed-off-by: Jon Maxwell <jmaxwell37@...il.com>

Acked-by: Michael Chan <michael.chan@...adcom.com>

We used to power down the chip in tg3_close() and that's why we cannot
do ethtool -p after close.  We don't do that any more so this is fine.
Thanks.