linux-kernel - Re: [Intel-gfx] linux-next: Tree for Mar 29 (i915, no ACPI)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87zhp8zj3e.fsf@intel.com>
Date:   Tue, 02 Apr 2019 15:29:09 +0300
From:   Jani Nikula <jani.nikula@...ux.intel.com>
To:     Randy Dunlap <rdunlap@...radead.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux Next Mailing List <linux-next@...r.kernel.org>
Cc:     intel-gfx <intel-gfx@...ts.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        dri-devel <dri-devel@...ts.freedesktop.org>
Subject: Re: [Intel-gfx] linux-next: Tree for Mar 29 (i915, no ACPI)

On Fri, 29 Mar 2019, Randy Dunlap <rdunlap@...radead.org> wrote:
> On 3/28/19 8:18 PM, Stephen Rothwell wrote:
>> Hi all,
>> 
>> Changes since 20190328:
>> 
>> The pidfd tree lost its build failures.
>> 
>
> on x86_64, when # CONFIG_ACPI is not set/enabled:
>
> ld: drivers/gpu/drm/i915/intel_panel.o: in function `intel_backlight_device_register':
> intel_panel.c:(.text+0x2c49): undefined reference to `backlight_device_register'
> ld: drivers/gpu/drm/i915/intel_panel.o: in function `intel_backlight_device_unregister':
> intel_panel.c:(.text+0x2d01): undefined reference to `backlight_device_unregister'
>
>
>
> Full randconfig file is attached.

# CONFIG_ACPI is not set
CONFIG_DRM_I915=y
CONFIG_BACKLIGHT_CLASS_DEVICE=m

drivers/gpu/drm/i915/Kconfig:

config DRM_I915
	# ...
	select BACKLIGHT_CLASS_DEVICE if ACPI

The above pretty much sums it up. It's been reported before, the
earliest I could find was [1].

I've previously suggested patches that would make backlight a dependency
instead of selecting it, in line with [2]. However we can't do that in
i915 alone without recursive dependencies, and changing all backlight
users was met with opposition because "select is convenient".

Maybe I'll look at this one of these days, but don't hold your breath.


BR,
Jani.


[1] http://mid.mail-archive.com/CA+r1ZhhmT4DrWtf6MbRQo5EqXwx+LxCqh15Vsu_d9WpftLhnxw@mail.gmail.com

[2] Documentation/kbuild/kconfig-language.txt "In general use select
    only for non-visible symbols (no prompts anywhere) and for symbols
    with no dependencies."

-- 
Jani Nikula, Intel Open Source Graphics Center