linux-kernel - Re: [PATCH v2] gcov: fix when CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKwvOd=PstHEm_Vxtx_SGanKhAJSjoQiCb3kgCVeK4peUF2k-g@mail.gmail.com>
Date:   Tue, 2 Apr 2019 09:54:50 +0700
From:   Nick Desaulniers <ndesaulniers@...gle.com>
To:     Tri Vo <trong@...roid.com>
Cc:     Randy Dunlap <rdunlap@...radead.org>,
        Peter Oberparleiter <oberpar@...ux.ibm.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Greg Hackmann <ghackmann@...roid.com>,
        Linux Memory Management List <linux-mm@...ck.org>,
        kbuild-all@...org, kbuild test robot <lkp@...el.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] gcov: fix when CONFIG_MODULES is not set

On Sun, Mar 31, 2019 at 6:57 AM Tri Vo <trong@...roid.com> wrote:
>
> On Fri, Mar 29, 2019 at 1:53 PM Randy Dunlap <rdunlap@...radead.org> wrote:
> >
> > On 3/29/19 11:18 AM, Nick Desaulniers wrote:
> > > Fixes commit 8c3d220cb6b5 ("gcov: clang support")
> >
> > There is a certain format for Fixes: and that's not quite it. :(

Looks like the format is:
Fixes: <first 12 characters of commit sha> ("<first line of commit>")
so:
Fixes: 8c3d220cb6b5 ("gcov: clang support")

We should update:
https://www.kernel.org/doc/html/v5.0/process/stable-kernel-rules.html
to include this information.

> Thanks for taking a look at this Nick! I believe same fix should be
> applied to kernel/gcov/clang.c. I'll send out an updated version later
> today.

All yours, happy to review.

-- 
Thanks,
~Nick Desaulniers