linux-kernel - [PATCH 1/3] ipuv3-crtc: add remove action for devres data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190402134904.588-2-m.grzeschik@pengutronix.de>
Date:   Tue,  2 Apr 2019 15:49:02 +0200
From:   Michael Grzeschik <m.grzeschik@...gutronix.de>
To:     p.zabel@...gutronix.de, airlied@...ux.ie,
        gregkh@...uxfoundation.org
Cc:     linux-kernel@...r.kernel.org, linux@...linux.org.uk,
        dri-devel@...ts.freedesktop.org, rafael@...nel.org,
        kernel@...gutronix.de
Subject: [PATCH 1/3] ipuv3-crtc: add remove action for devres data

The destroy function in drm_mode_config_cleanup will remove the objects
in ipu-drm-core by calling its destroy functions if the bind function
fails. The drm_crtc is also part of the devres allocated ipu_crtc
object. The ipu_crtc object will already be cleaned up if the bind for
the crtc fails. This leads drm_crtc_cleanup try to clean already freed
memory.

We fix this issue by adding the devres action ipu_crtc_remove_head which
will remove its head from the objects in ipu-drm-core which then never
calls its destroy function anymore.

Signed-off-by: Michael Grzeschik <m.grzeschik@...gutronix.de>
---
 drivers/gpu/drm/imx/ipuv3-crtc.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/drivers/gpu/drm/imx/ipuv3-crtc.c b/drivers/gpu/drm/imx/ipuv3-crtc.c
index ec3602ebbc1cd..fa1ee33a43d77 100644
--- a/drivers/gpu/drm/imx/ipuv3-crtc.c
+++ b/drivers/gpu/drm/imx/ipuv3-crtc.c
@@ -429,6 +429,14 @@ static int ipu_crtc_init(struct ipu_crtc *ipu_crtc,
 	return ret;
 }
 
+static void ipu_crtc_remove_head(void *data)
+{
+	struct ipu_crtc *ipu_crtc = data;
+	struct drm_crtc *crtc = &ipu_crtc->base;
+
+	list_del(&crtc->head);
+}
+
 static int ipu_drm_bind(struct device *dev, struct device *master, void *data)
 {
 	struct ipu_client_platformdata *pdata = dev->platform_data;
@@ -440,6 +448,10 @@ static int ipu_drm_bind(struct device *dev, struct device *master, void *data)
 	if (!ipu_crtc)
 		return -ENOMEM;
 
+	ret = devm_add_action(dev, ipu_crtc_remove_head, ipu_crtc);
+	if (ret)
+		return ret;
+
 	ipu_crtc->dev = dev;
 
 	ret = ipu_crtc_init(ipu_crtc, pdata, drm);
-- 
2.20.1