linux-kernel - Re: [PATCH] arm64: vdso: fix and clean-up Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNAQ4aabQoMwWZNUEACPC3_SQPdmq+5cAOQD-d+yvXE7Qzg@mail.gmail.com>
Date:   Thu, 4 Apr 2019 02:04:23 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Will Deacon <will.deacon@....com>
Cc:     Catalin Marinas <catalin.marinas@....com>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arm64: vdso: fix and clean-up Makefile

Hi Will,

On Wed, Apr 3, 2019 at 9:45 PM Will Deacon <will.deacon@....com> wrote:
>
> Hi Masahiro,
>
> On Wed, Apr 03, 2019 at 05:48:22PM +0900, Masahiro Yamada wrote:
> > - $(call if_changed,...) must have FORCE as a prerequisite
> >
> > - vdso.lds is a generated file, so it should be prefixed with
> >   $(obj)/ instead of $(src)/.
>
> Hmm, this sounds quite alarming! How come out of tree builds seem to work
> ok without this patch?

No, I do not mean like that.
This is just cosmetic (at least for now).
Kbuild conventionally use both $(obj) and $(src), but
they are the same in most places.
If you see the top of scripts/Makefile.build,
$(src) is the same as $(obj).


I fixed this x86 in commit 1742ed2088.
VDSO Makefiles are copied from arch to arch.

-- 
Best Regards
Masahiro Yamada