linux-kernel - Re: dell_smbios KASAN bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190403131654.7379a991@gandalf.local.home>
Date:   Wed, 3 Apr 2019 13:16:54 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Tom Zanussi <tzanussi@...il.com>
Cc:     Mario.Limonciello@...l.com, pali.rohar@...il.com,
        linux-kernel@...r.kernel.org
Subject: Re: dell_smbios KASAN bug

On Mon, 25 Mar 2019 11:20:47 -0500
Tom Zanussi <tzanussi@...il.com> wrote:

> > Is it OK if I add the following tags to that patch?
> > 
> > Reported-by: Tom Zanussi <tzanussi@...il.com>
> > Tested-by: Tom Zanussi <tzanussi@...il.com>
> >   
> 
> Yep, fine with me.

I modified the patch slightly. Can you test this too. There should be
no reason that it wont work as this is "safer" but I don't want to put
your tested-by if you haven't tested it ;-)

-- Steve

diff --git a/drivers/platform/x86/dell-smbios-base.c b/drivers/platform/x86/dell-smbios-base.c
index 0537d44d45a6..a74c0df25b15 100644
--- a/drivers/platform/x86/dell-smbios-base.c
+++ b/drivers/platform/x86/dell-smbios-base.c
@@ -625,6 +625,8 @@ static int __init dell_smbios_init(void)
 
 fail_platform_driver:
 	kfree(da_tokens);
+	da_tokens = NULL;
+	da_num_tokens = 0;
 	return ret;
 }