linux-kernel - Re: [PATCH v2] platform/chrome: cros_ec_spi: Transfer messages at high priority

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=UC6MpTgmir+nwUy4hWk8Vvz97M5G45=-r5JAg_=z6vQQ@mail.gmail.com>
Date:   Wed, 3 Apr 2019 11:17:27 -0700
From:   Doug Anderson <dianders@...omium.org>
To:     Matthias Kaehlcke <mka@...omium.org>
Cc:     Brian Norris <briannorris@...omium.org>,
        Benson Leung <bleung@...omium.org>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Alexandru M Stan <amstan@...omium.org>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
        Simon Glass <sjg@...omium.org>,
        Guenter Roeck <groeck@...omium.org>,
        Mark Brown <broonie@...nel.org>,
        Ryan Case <ryandcase@...omium.org>,
        Randall Spangler <rspangler@...omium.org>,
        Heiko Stuebner <heiko@...ech.de>,
        Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] platform/chrome: cros_ec_spi: Transfer messages at
 high priority

Hi,

On Wed, Apr 3, 2019 at 11:14 AM Matthias Kaehlcke <mka@...omium.org> wrote:
> Each transfer has it's own work struct (allocated on the stack), hence
> a) does not occur. b) is still true, but shouldn't be a problem on
> its own.

Actually, it could be much worse _because_ it's on the stack.  The
worker could write something back to the work after the work has been
de-allocated.  That's bad.


> Anyway, using flush_work() as you suggested is the better solution :)

Yup, thanks!