linux-kernel - Re: [PATCH] vfio/spapr_tce: Make symbol 'tce_iommu_driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 3 Apr 2019 12:52:22 -0600
From:   Alex Williamson <alex.williamson@...hat.com>
To:     Wang Hai <wanghai26@...wei.com>
Cc:     <kvm@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] vfio/spapr_tce: Make symbol 'tce_iommu_driver_ops'
 static

On Wed, 20 Mar 2019 02:47:23 -0400
Wang Hai <wanghai26@...wei.com> wrote:

> Fixes the following sparse warning:
> 
> drivers/vfio/vfio_iommu_spapr_tce.c:1401:36: warning:
>  symbol 'tce_iommu_driver_ops' was not declared. Should it be static?
> 
> Fixes: 5ffd229c0273 ("powerpc/vfio: Implement IOMMU driver for VFIO")
> Signed-off-by: Wang Hai <wanghai26@...wei.com>
> ---

Applied to vfio for-linus branch for v5.1 with Alexey's R-b.  Thanks!

Alex

>  drivers/vfio/vfio_iommu_spapr_tce.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/vfio/vfio_iommu_spapr_tce.c b/drivers/vfio/vfio_iommu_spapr_tce.c
> index 8dbb270..6b64e45 100644
> --- a/drivers/vfio/vfio_iommu_spapr_tce.c
> +++ b/drivers/vfio/vfio_iommu_spapr_tce.c
> @@ -1398,7 +1398,7 @@ static void tce_iommu_detach_group(void *iommu_data,
>  	mutex_unlock(&container->lock);
>  }
>  
> -const struct vfio_iommu_driver_ops tce_iommu_driver_ops = {
> +static const struct vfio_iommu_driver_ops tce_iommu_driver_ops = {
>  	.name		= "iommu-vfio-powerpc",
>  	.owner		= THIS_MODULE,
>  	.open		= tce_iommu_open,