linux-kernel - Re: [Lkcamp] [PATCH] staging/rtl8723bs: Fix code indent.

Open Source and information security mailing list archives

Message-ID: <CAPW4XYZpmPaP01UQbKFQSMh_FT20M467zhuETNwcHwbNP4uFoA@mail.gmail.com>
Date:   Wed, 3 Apr 2019 17:22:02 -0300
From:   Helen Koike <helen@...keco.de>
To:     Beatriz Martins de Carvalho <martinsdecarvalhobeatriz@...il.com>
Cc:     Greg KH <gregkh@...uxfoundation.org>, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, lkcamp@...ts.libreplanetbr.org
Subject: Re: [Lkcamp] [PATCH] staging/rtl8723bs: Fix code indent.

Hi Beatriz,

Thank you for the patch, just some small comments.

Regarding the patch title, if you run

    git log drivers/staging/rtl8723bs/hal/hal_com_phycfg.c

You will see that commits starts with the following tags "staging:
rtl8723bs: <commit title>"

Also, try to add a bit more information to the title, for example:

"staging: rtl8723bs: replace spaces by tabs"

See my other comments below:

On Wed, Apr 3, 2019 at 3:42 PM Beatriz Martins de Carvalho
<martinsdecarvalhobeatriz@...il.com> wrote:
>
> Fix Error: code indent

Please, add more information to your messages, you can add which
checkpatch error you fixed.
See this example: https://lkml.org/lkml/2019/4/2/1184

Please, re-submit version 2 of this patch, it should start with: [PATCH v2]
If you are using git send-email, you can use the option "-v2" and it
will fix the title for you.
Remember to add a change log, see this example:
https://marc.info/?l=linux-kernel&m=154201089629031&w=2
See the change log after the "---". It is important to be after the
triple dashes, as this is a comment to help reviewers and it is not
meant for mainline.

I hope this helps! Let me know if you have any questions :)

Regards,
Helen

>
> Signed-off-by: Beatriz Martins de Carvalho <martinsdecarvalhobeatriz@...il.com>
> ---
>  drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
> index 828b328adab8..fc49cdfcd477 100644
> --- a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
> +++ b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
> @@ -1723,7 +1723,7 @@ s8 phy_get_tx_pwr_lmt(struct adapter *adapter, u32 reg_pwr_tbl_sel,
>         idx_rate_sctn = get_rate_sctn_idx(data_rate);
>
>         if (band_type == BAND_ON_5G && idx_rate_sctn == 0)
> -                DBG_871X("Wrong rate 0x%x: No CCK in 5G Band\n", DataRate);
> +               DBG_871X("Wrong rate 0x%x: No CCK in 5G Band\n", DataRate);
>
>         /*  workaround for wrong index combination to obtain tx power limit, */
>         /*  OFDM only exists in BW 20M */
> --
> 2.17.1
>
>
> _______________________________________________
> Lkcamp mailing list
> Lkcamp@...ts.libreplanetbr.org
> https://lists.libreplanetbr.org/mailman/listinfo/lkcamp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives