linux-kernel - Re: [PATCH] locking/lockdep: Zap lock classes even with lock debugging disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1554326129.118779.234.camel@acm.org>
Date:   Wed, 03 Apr 2019 14:15:29 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     Will Deacon <will.deacon@....com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-kernel@...r.kernel.org, Waiman Long <longman@...hat.com>,
        shenghui <shhuiw@...mail.com>
Subject: Re: [PATCH] locking/lockdep: Zap lock classes even with lock
 debugging disabled

On Wed, 2019-04-03 at 13:44 +0100, Will Deacon wrote:
> > --- a/kernel/locking/lockdep.c
> > +++ b/kernel/locking/lockdep.c
> > @@ -4689,8 +4689,7 @@ static void free_zapped_rcu(struct rcu_head *ch)
> >  		return;
> >  
> >  	raw_local_irq_save(flags);
> > -	if (!graph_lock())
> > -		goto out_irq;
> > +	arch_spin_lock(&lockdep_lock);
> 
> This also throws out the recursion counting. Is that ok?

Apparently not, as the build bot just figured out. I will restore recursion
counting. See also
https://lore.kernel.org/lkml/5ca4ea66.eVtXtf5CmqRjP7xF%25lkp@intel.com/.

Bart.