linux-kernel - Re: [PATCH] i2c: isch: Remove unnecessary acpi.h include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 3 Apr 2019 17:27:14 -0500
From:   Bjorn Helgaas <bhelgaas@...gle.com>
To:     Wolfram Sang <wsa@...-dreams.de>
Cc:     Bjorn Helgaas <helgaas@...nel.org>,
        Jean Delvare <jdelvare@...e.com>,
        linux-i2c <linux-i2c@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Mukesh Ojha <mojha@...eaurora.org>
Subject: Re: [PATCH] i2c: isch: Remove unnecessary acpi.h include

On Wed, Apr 3, 2019 at 3:57 PM Wolfram Sang <wsa@...-dreams.de> wrote:
>
> On Mon, Apr 01, 2019 at 02:37:19PM -0500, Bjorn Helgaas wrote:
> > On Mon, Apr 1, 2019 at 9:08 AM Wolfram Sang <wsa@...-dreams.de> wrote:
> > >
> > >
> > > > > From: Bjorn Helgaas <bhelgaas@...gle.com>
> > > > >
> > > > > 54fb4a05af0a ("i2c: Check for ACPI resource conflicts") included
> > > > > <linux/acpi.h> so we could use acpi_check_region().  fd46a0064af1 ("i2c:
> > > > > convert i2c-isch to platform_device") removed the use of
> > > > > acpi_check_region() but not the include.
> > > > >
> > > > > Remove the now-unnecessary include of <linux/acpi.h>.  No functional change
> > > > > intended.
> > > > >
> > > > > Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>
> > > >
> > > > Added
> > > >
> > > >     Fixes: fd46a0064af1 ("i2c: convert i2c-isch to platform_device")
> > > >     Reviewed-by: Jean Delvare <jdelvare@...e.de>
> > > >     Reviewed-by: Mukesh Ojha <mojha@...eaurora.org>
> > > >
> > > > on my local branch.
> > > >
> > > > Jean, would you like me to repost this with the updates?  I assume you
> > > > will merge this (just based on get_maintainer.pl)?
> > >
> > > I will apply it, now that it has Jean's Rev-by. I assume this is
> > > for-next material despite the Fixes tag?
> >
> > Definitely for-next material, not for the current release.  Jean
> > suggested the Fixes tag, I think since it's related to a specific
> > commit and could be backported together with that commit.
> >
> > Should there be a MAINTAINERS update to clarify who applies patches to
> > drivers/i2c/busses/i2c-isch.c?  Right now, get_maintainers.pl doesn't
> > mention you (Wolfram).
> >
> > Patch with tags attached in case it's useful to you (sorry, I'm
> > saddled with gmail right now and can't include it inline).
>
> > From 36fbdab89f5b8aa2d3616bd289e2c695fd3c0f9b Mon Sep 17 00:00:00 2001
> > From: Bjorn Helgaas <bhelgaas@...gle.com>
> > Date: Tue, 30 Oct 2018 14:12:36 -0500
> > Subject: [PATCH] i2c: isch: Remove unnecessary acpi.h include
> >
> > 54fb4a05af0a ("i2c: Check for ACPI resource conflicts") included
> > <linux/acpi.h> so we could use acpi_check_region().  fd46a0064af1 ("i2c:
> > convert i2c-isch to platform_device") removed the use of
> > acpi_check_region() but not the include.
> >
> > Remove the now-unnecessary include of <linux/acpi.h>.  No functional change
> > intended.
> >
> > Fixes: fd46a0064af1 ("i2c: convert i2c-isch to platform_device")
> > Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>
> > Reviewed-by: Jean Delvare <jdelvare@...e.de>
> > Reviewed-by: Mukesh Ojha <mojha@...eaurora.org>
>
> Fixed this checkpatch error:
>
> ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit fd46a0064af1 ("i2c: convert i2c-isch to platform_device")'

Thanks, I didn't even know about that requirement for the word
"commit"!  I assume this only applies in the text, not in the "Fixes:"
tag.