linux-kernel - Re: [PATCH] mm: __pagevec_lru_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 3 Apr 2019 09:45:59 +0200
From:   Vlastimil Babka <vbabka@...e.cz>
To:     Peng Fan <peng.fan@....com>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "mhocko@...e.com" <mhocko@...e.com>,
        "willy@...radead.org" <willy@...radead.org>,
        "rppt@...ux.vnet.ibm.com" <rppt@...ux.vnet.ibm.com>,
        "arunks@...eaurora.org" <arunks@...eaurora.org>,
        "nborisov@...e.com" <nborisov@...e.com>,
        "dan.j.williams@...el.com" <dan.j.williams@...el.com>,
        "aryabinin@...tuozzo.com" <aryabinin@...tuozzo.com>,
        "ldr709@...il.com" <ldr709@...il.com>
Cc:     "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "van.freenix@...il.com" <van.freenix@...il.com>
Subject: Re: [PATCH] mm: __pagevec_lru_add_fn: typo fix

On 4/2/19 11:43 AM, Peng Fan wrote:
> There is no function named munlock_vma_pages, correct it to
> munlock_vma_page.
> 
> Signed-off-by: Peng Fan <peng.fan@....com>

Acked-by: Vlastimil Babka <vbabka@...e.cz>

> ---
>  mm/swap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/swap.c b/mm/swap.c
> index 301ed4e04320..3a75722e68a9 100644
> --- a/mm/swap.c
> +++ b/mm/swap.c
> @@ -867,7 +867,7 @@ static void __pagevec_lru_add_fn(struct page *page, struct lruvec *lruvec,
>  	SetPageLRU(page);
>  	/*
>  	 * Page becomes evictable in two ways:
> -	 * 1) Within LRU lock [munlock_vma_pages() and __munlock_pagevec()].
> +	 * 1) Within LRU lock [munlock_vma_page() and __munlock_pagevec()].
>  	 * 2) Before acquiring LRU lock to put the page to correct LRU and then
>  	 *   a) do PageLRU check with lock [check_move_unevictable_pages]
>  	 *   b) do PageLRU check before lock [clear_page_mlock]
>