linux-kernel - Re: [PATCH 1/6] arm64/mm: Enable sysfs based memory hot add interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4b9dd2b0-3b11-608c-1a40-9a3d203dd904@redhat.com>
Date:   Wed, 3 Apr 2019 10:20:32 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Anshuman Khandual <anshuman.khandual@....com>,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mm@...ck.org, akpm@...ux-foundation.org, will.deacon@....com,
        catalin.marinas@....com
Cc:     mhocko@...e.com, mgorman@...hsingularity.net, james.morse@....com,
        mark.rutland@....com, robin.murphy@....com, cpandya@...eaurora.org,
        arunks@...eaurora.org, dan.j.williams@...el.com, osalvador@...e.de,
        logang@...tatee.com, pasha.tatashin@...cle.com, cai@....pw
Subject: Re: [PATCH 1/6] arm64/mm: Enable sysfs based memory hot add interface

On 03.04.19 06:30, Anshuman Khandual wrote:
> Sysfs memory probe interface (/sys/devices/system/memory/probe) can accept
> starting physical address of an entire memory block to be hot added into
> the kernel. This is in addition to the existing ACPI based interface. This
> just enables it with the required config CONFIG_ARCH_MEMORY_PROBE.
> 

We recently discussed that the similar interface for removal should
rather be moved to a debug/test module

I wonder if we should try to do the same for the sysfs probing
interface. Rather try to get rid of it than open the doors for more users.

> Signed-off-by: Anshuman Khandual <anshuman.khandual@....com>
> ---
>  arch/arm64/Kconfig | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 7e34b9e..a2418fb 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -266,6 +266,15 @@ config HAVE_GENERIC_GUP
>  config ARCH_ENABLE_MEMORY_HOTPLUG
>  	def_bool y
>  
> +config ARCH_MEMORY_PROBE
> +	bool "Enable /sys/devices/system/memory/probe interface"
> +	depends on MEMORY_HOTPLUG
> +	help
> +	  This option enables a sysfs /sys/devices/system/memory/probe
> +	  interface for testing. See Documentation/memory-hotplug.txt
> +	  for more information. If you are unsure how to answer this
> +	  question, answer N.
> +
>  config SMP
>  	def_bool y
>  
> 


-- 

Thanks,

David / dhildenb