linux-kernel - Re: [PATCH v4 3/5] media: sunxi: Add A10 CSI driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190403092655.engthyfinpxvndh4@flea>
Date:   Wed, 3 Apr 2019 11:26:55 +0200
From:   Maxime Ripard <maxime.ripard@...tlin.com>
To:     Sakari Ailus <sakari.ailus@...ux.intel.com>
Cc:     Hans Verkuil <hans.verkuil@...co.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        linux-media@...r.kernel.org, Chen-Yu Tsai <wens@...e.org>,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        devicetree@...r.kernel.org, Mark Rutland <mark.rutland@....com>,
        Rob Herring <robh+dt@...nel.org>,
        Frank Rowand <frowand.list@...il.com>
Subject: Re: [PATCH v4 3/5] media: sunxi: Add A10 CSI driver

Hi Sakari,

On Wed, Apr 03, 2019 at 12:12:21PM +0300, Sakari Ailus wrote:
> Thanks for the update and my apologies for the late review.
>
> On Tue, Mar 19, 2019 at 04:55:46PM +0100, Maxime Ripard wrote:
> > The older CSI drivers have camera capture interface different from the one
> > in the newer ones.
> >
> > This IP is pretty simple. Some variants (one controller out of two
> > instances on some SoCs) have an ISP embedded, but there's no code that make
> > use of it, so we ignored that part for now.
> >
> > Signed-off-by: Maxime Ripard <maxime.ripard@...tlin.com>
>
> Could you add a sub-device for the CSI-2 receiver, please?
>
> See e.g. drivers/media/pci/intel/ipu3/ipu3-cio2.c for an example.

It's confusing, I know, but this isn't a MIPI-CSI receiver. The IP is
called CSI, but it's only capable of handling parallel and BT656.

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)