linux-kernel - Re: [PATCH v2 1/3] dmaengine: at_xdmac: remove BUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9b744b6c-7d16-3225-0457-2e1193237954@microchip.com>
Date:   Wed, 3 Apr 2019 10:22:42 +0000
From:   <Nicolas.Ferre@...rochip.com>
To:     <dmaengine@...r.kernel.org>, <vkoul@...nel.org>
CC:     <Ludovic.Desroches@...rochip.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <alexandre.belloni@...tlin.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/3] dmaengine: at_xdmac: remove BUG_ON macro in
 tasklet

Vinod,

Please disregard this series: I'm sending a v3 right now. Sorry for the 
noise.

Best regards,
   Nicolas

On 03/04/2019 at 12:09, Nicolas Ferre wrote:
> Even if this case shouldn't happen when controller is properly programmed,
> it's still better to avoid dumping a kernel Oops for this.
> As the sequence may happen only for debugging purposes, log the error and
> just finish the tasklet call.
> 
> Signed-off-by: Nicolas Ferre <nicolas.ferre@...rochip.com>
> Acked-by: Ludovic Desroches <ludovic.desroches@...rochip.com>
> ---
> v2: added Ludovic's tag
> 
>   drivers/dma/at_xdmac.c | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c
> index fe69dccfa0c0..37a269420435 100644
> --- a/drivers/dma/at_xdmac.c
> +++ b/drivers/dma/at_xdmac.c
> @@ -1606,7 +1606,11 @@ static void at_xdmac_tasklet(unsigned long data)
>   					struct at_xdmac_desc,
>   					xfer_node);
>   		dev_vdbg(chan2dev(&atchan->chan), "%s: desc 0x%p\n", __func__, desc);
> -		BUG_ON(!desc->active_xfer);
> +		if (!desc->active_xfer) {
> +			dev_err(chan2dev(&atchan->chan), "Xfer not active: exiting");
> +			spin_unlock_bh(&atchan->lock);
> +			return;
> +		}
>   
>   		txd = &desc->tx_dma_desc;
>   
> 


-- 
Nicolas Ferre