linux-kernel - [tip:sched/core] rcuwait: Annotate task_struct with _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tip-03f4b48edae7d936c5bf23488c1ce3fbe7fc2733@git.kernel.org>
Date:   Wed, 3 Apr 2019 03:47:33 -0700
From:   "tip-bot for Joel Fernandes (Google)" <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     rostedt@...dmis.org, morten.rasmussen@....com, hpa@...or.com,
        mingo@...nel.org, tglx@...utronix.de, linux-kernel@...r.kernel.org,
        paulmck@...ux.ibm.com, josh@...htriplett.org, efault@....de,
        joel@...lfernandes.org, jiangshanlai@...il.com,
        luc.vanoostenryck@...il.com, peterz@...radead.org,
        torvalds@...ux-foundation.org, mathieu.desnoyers@...icios.com
Subject: [tip:sched/core] rcuwait: Annotate task_struct with __rcu

Commit-ID:  03f4b48edae7d936c5bf23488c1ce3fbe7fc2733
Gitweb:     https://git.kernel.org/tip/03f4b48edae7d936c5bf23488c1ce3fbe7fc2733
Author:     Joel Fernandes (Google) <joel@...lfernandes.org>
AuthorDate: Wed, 20 Mar 2019 20:34:25 -0400
Committer:  Ingo Molnar <mingo@...nel.org>
CommitDate: Wed, 3 Apr 2019 12:34:31 +0200

rcuwait: Annotate task_struct with __rcu

This suppresses sparse error generated due to the recently added
rcu_assign_pointer sparse check.

  percpu-rwsem.c:162:9: sparse: error: incompatible types in comparison expression
  exit.c:316:16: sparse: error: incompatible types in comparison expression

Signed-off-by: Joel Fernandes (Google) <joel@...lfernandes.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org>
[ From an RCU perspective. ]
Reviewed-by: Paul E. McKenney <paulmck@...ux.ibm.com>
Cc: Josh Triplett <josh@...htriplett.org>
Cc: Lai Jiangshan <jiangshanlai@...il.com>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Luc Van Oostenryck <luc.vanoostenryck@...il.com>
Cc: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
Cc: Mike Galbraith <efault@....de>
Cc: Morten Rasmussen <morten.rasmussen@....com>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: Steven Rostedt <rostedt@...dmis.org>
Cc: Thomas Gleixner <tglx@...utronix.de>
Cc: keescook@...omium.org
Cc: kernel-hardening@...ts.openwall.com
Cc: kernel-team@...roid.com
Link: https://lkml.kernel.org/r/20190321003426.160260-4-joel@joelfernandes.org
Signed-off-by: Ingo Molnar <mingo@...nel.org>
---
 include/linux/rcuwait.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/rcuwait.h b/include/linux/rcuwait.h
index 90bfa3279a01..563290fc194f 100644
--- a/include/linux/rcuwait.h
+++ b/include/linux/rcuwait.h
@@ -18,7 +18,7 @@
  * awoken.
  */
 struct rcuwait {
-	struct task_struct *task;
+	struct task_struct __rcu *task;
 };
 
 #define __RCUWAIT_INITIALIZER(name)		\