linux-kernel - [tip:sched/core] sched/core: Annotate perf_domain pointer with _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tip-7ba7319f9e3898101bff5d63cbae5a6cc174c8c9@git.kernel.org>
Date:   Wed, 3 Apr 2019 03:48:13 -0700
From:   "tip-bot for Joel Fernandes (Google)" <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     josh@...htriplett.org, linux-kernel@...r.kernel.org,
        tglx@...utronix.de, torvalds@...ux-foundation.org,
        rostedt@...dmis.org, mingo@...nel.org, morten.rasmussen@....com,
        jiangshanlai@...il.com, paulmck@...ux.ibm.com,
        joel@...lfernandes.org, luc.vanoostenryck@...il.com, hpa@...or.com,
        mathieu.desnoyers@...icios.com, peterz@...radead.org, efault@....de
Subject: [tip:sched/core] sched/core: Annotate perf_domain pointer with
 __rcu

Commit-ID:  7ba7319f9e3898101bff5d63cbae5a6cc174c8c9
Gitweb:     https://git.kernel.org/tip/7ba7319f9e3898101bff5d63cbae5a6cc174c8c9
Author:     Joel Fernandes (Google) <joel@...lfernandes.org>
AuthorDate: Wed, 20 Mar 2019 20:34:26 -0400
Committer:  Ingo Molnar <mingo@...nel.org>
CommitDate: Wed, 3 Apr 2019 12:34:31 +0200

sched/core: Annotate perf_domain pointer with __rcu

This fixes the following sparse errors in sched/fair.c:

  fair.c:6506:14: error: incompatible types in comparison expression
  fair.c:8642:21: error: incompatible types in comparison expression

Using __rcu will also help sparse catch any future bugs.

Signed-off-by: Joel Fernandes (Google) <joel@...lfernandes.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org>
[ From an RCU perspective. ]
Reviewed-by: Paul E. McKenney <paulmck@...ux.ibm.com>
Cc: Josh Triplett <josh@...htriplett.org>
Cc: Lai Jiangshan <jiangshanlai@...il.com>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Luc Van Oostenryck <luc.vanoostenryck@...il.com>
Cc: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
Cc: Mike Galbraith <efault@....de>
Cc: Morten Rasmussen <morten.rasmussen@....com>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: Steven Rostedt <rostedt@...dmis.org>
Cc: Thomas Gleixner <tglx@...utronix.de>
Cc: keescook@...omium.org
Cc: kernel-hardening@...ts.openwall.com
Cc: kernel-team@...roid.com
Link: https://lkml.kernel.org/r/20190321003426.160260-5-joel@joelfernandes.org
Signed-off-by: Ingo Molnar <mingo@...nel.org>
---
 kernel/sched/sched.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index 2b452d68ab2e..b52ed1ada0be 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -780,7 +780,7 @@ struct root_domain {
 	 * NULL-terminated list of performance domains intersecting with the
 	 * CPUs of the rd. Protected by RCU.
 	 */
-	struct perf_domain	*pd;
+	struct perf_domain __rcu *pd;
 };
 
 extern struct root_domain def_root_domain;