linux-kernel - Re: [PATCH] watchdog: Convert to use devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 3 Apr 2019 00:22:54 +0000
From:   Joel Stanley <joel@....id.au>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Wim Van Sebroeck <wim@...ux-watchdog.org>,
        LINUXWATCHDOG <linux-watchdog@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Baruch Siach <baruch@...s.co.il>,
        Keguang Zhang <keguang.zhang@...il.com>,
        Vladimir Zapolskiy <vz@...ia.com>,
        Kevin Hilman <khilman@...libre.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Avi Fishman <avifishman70@...il.com>,
        Nancy Yuen <yuenn@...gle.com>,
        Brendan Higgins <brendanhiggins@...gle.com>,
        Wan ZongShun <mcuos.com@...il.com>,
        Michal Simek <michal.simek@...inx.com>,
        Sylvain Lemieux <slemieux.tyco@...il.com>,
        Kukjin Kim <kgene@...nel.org>, Barry Song <baohua@...nel.org>,
        Orson Zhai <orsonzhai@...il.com>,
        Patrice Chotard <patrice.chotard@...com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Maxime Ripard <maxime.ripard@...tlin.com>,
        Chen-Yu Tsai <wens@...e.org>,
        Marc Gonzalez <marc.w.gonzalez@...e.fr>,
        Thierry Reding <thierry.reding@...il.com>,
        Shawn Guo <shawnguo@...nel.org>
Subject: Re: [PATCH] watchdog: Convert to use devm_platform_ioremap_resource

On Tue, 2 Apr 2019 at 19:02, Guenter Roeck <linux@...ck-us.net> wrote:
>
> Use devm_platform_ioremap_resource to reduce source code size,

This is a strange name for a function that doesn't take nor return a
'struct resource'.

However, the intent is welcome as many drivers do redundant checking
of the platform_get_resource result before passing to
devm_ioremap_resource.

> improve readability, and reduce the likelyhood of bugs.

>  drivers/watchdog/aspeed_wdt.c     | 4 +---

Acked-by: Joel Stanley <joel@....id.au>

Cheers,

Joel