linux-kernel - Re: 答复: Re: [PATCH v2 14/15] arm64: cpu_ops: fix a leaked reference byadding missing of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20190403124429.GG16362@fuggles.cambridge.arm.com>
Date:   Wed, 3 Apr 2019 13:44:29 +0100
From:   Will Deacon <will.deacon@....com>
To:     wen.yang99@....com.cn
Cc:     linux-kernel@...r.kernel.org, wang.yi59@....com.cn,
        catalin.marinas@....com, linux-arm-kernel@...ts.infradead.org
Subject: Re: 答复: Re: [PATCH v2 14/15] arm64: cpu_ops: fix a leaked
 reference byadding missing of_node_put

On Wed, Apr 03, 2019 at 01:56:09PM +0800, wen.yang99@....com.cn wrote:
> > > The call to of_get_next_child returns a node pointer with refcount
> > > incremented thus it must be explicitly decremented after the last
> > > usage.
> > >
> > > Detected by coccinelle with the following warnings:
> > > ./arch/arm64/kernel/cpu_ops.c:102:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 69, but without a corresponding object release within this function.
> > >
> > > Signed-off-by: Wen Yang <wen.yang99@....com.cn>
> > > Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
> > > Cc: Catalin Marinas <catalin.marinas@....com>
> > > Cc: Will Deacon <will.deacon@....com>
> > > Cc: linux-arm-kernel@...ts.infradead.org
> > > Cc: linux-kernel@...r.kernel.org
> > > ---
> > > v2->v1: add a missing space between "adding" and "missing"
> > >
> > >  arch/arm64/kernel/cpu_ops.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/arch/arm64/kernel/cpu_ops.c b/arch/arm64/kernel/cpu_ops.c
> > > index ea00124..00f8b86 100644
> > > --- a/arch/arm64/kernel/cpu_ops.c
> > > +++ b/arch/arm64/kernel/cpu_ops.c
> > > @@ -85,6 +85,7 @@ static const char *__init cpu_read_enable_method(int cpu)
> > >                  pr_err("%pOF: missing enable-method property\n",
> > >                      dn);
> > >          }
> > > +        of_node_put(dn);
> > >      } else {
> > >          enable_method = acpi_get_enable_method(cpu);
> > >          if (!enable_method) {
> > 
> > Looks about right to me:
> > 
> > Acked-by: Will Deacon <will.deacon@....com>
> > 
> > How do you plan to get this upstream? Can we just pick this one up via
> > arm64?
> 
> Ok, thank you.
> We are very happy to know that it is useful.

Ok, I picked it up.

Will