linux-kernel - Re: [PATCH v4 0/5] PCI: dwc: Support remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 3 Apr 2019 19:06:15 +0530
From:   Vidya Sagar <vidyas@...dia.com>
To:     Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Jisheng Zhang <Jisheng.Zhang@...aptics.com>
CC:     Jingoo Han <jingoohan1@...il.com>,
        Gustavo Pimentel <gustavo.pimentel@...opsys.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Robin Murphy <robin.murphy@....com>
Subject: Re: [PATCH v4 0/5] PCI: dwc: Support remove

Verified it with Tegra194 PCIe host controller driver, but had to do
EXPORT_SYMBOL_GPL() for a bunch of APIs.
I'll push changes to export all those APIs as part of Tegra194 PCIe driver patch series.

Thanks
Vidya Sagar

On 4/1/2019 7:20 PM, Lorenzo Pieralisi wrote:
> On Fri, Mar 29, 2019 at 11:55:36AM +0000, Jisheng Zhang wrote:
>> Currently, the PCI dwc host users don't support the remove, but nothing
>> prevent us from supporting it. To achieve this goal, we need to ensure
>> we can do necessary clean up work.
>>
>> Changes since v3:
>>    - add Gustavo's ACK to patch2, patch5
>>    - remove IS_ENABLED(CONFIG_PCI_MSI) check
>>
>> Changes since v2:
>>    - address all Gustavo's comments
>>    - add Gustavo's ACK to patch1, patch3, patch4
>>
>> Changes since v1:
>>    - address Bjorn's comments, I.E Capitalize, s/irq/IRQ/, s/msi/MSI/
>>
>>
>> Jisheng Zhang (5):
>>    PCI: dwc: Fix dw_pcie_free_msi() if msi_irq is invalid
>>    PCI: dwc: Free the page for MSI IRQ in dw_pcie_free_msi()
>>    PCI: dwc: Free MSI in the error code path of dw_pcie_host_init()
>>    PCI: dwc: Use devm_pci_alloc_host_bridge() to simplify the code
>>    PCI: dwc: Save root bus for driver remove
>>
>>   .../pci/controller/dwc/pcie-designware-host.c | 60 ++++++++++---------
>>   drivers/pci/controller/dwc/pcie-designware.h  |  2 +
>>   2 files changed, 34 insertions(+), 28 deletions(-)
>   
> Applied to pci/dwc for v5.2, thanks.
> 
> Lorenzo
>