lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 3 Apr 2019 13:42:36 +0000 From: David Laight <David.Laight@...LAB.COM> To: 'Matthew Garrett' <matthewgarrett@...gle.com>, "linux-integrity@...r.kernel.org" <linux-integrity@...r.kernel.org> CC: "peterhuewe@....de" <peterhuewe@....de>, "jarkko.sakkinen@...ux.intel.com" <jarkko.sakkinen@...ux.intel.com>, "jgg@...pe.ca" <jgg@...pe.ca>, "roberto.sassu@...wei.com" <roberto.sassu@...wei.com>, "linux-efi@...r.kernel.org" <linux-efi@...r.kernel.org>, "linux-security-module@...r.kernel.org" <linux-security-module@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "tweek@...gle.com" <tweek@...gle.com>, Matthew Garrett <mjg59@...gle.com> Subject: RE: [PATCH 1/2] efi: Fix cast to pointer from integer of different size in TPM log code From: Matthew Garrett > Sent: 02 April 2019 22:56 > > 8bfcff4a6a1d9d7226bb63a7da758b82d9ab4373 introduced a cast from > efi_physical_address_t to (void *), which are different sizes on 32-bit. > Fix that. Caught by the 0-day test bot. Casting a physical address to 'void *' seems completely wrong. Also you'd need a guarantee that the address was below 4G or the result is meaningless. Looks to me like something is using the wrong types somewhere. David > Signed-off-by: Matthew Garrett <mjg59@...gle.com> > --- > drivers/firmware/efi/libstub/tpm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/firmware/efi/libstub/tpm.c b/drivers/firmware/efi/libstub/tpm.c > index b6e93e14fcf1..6b3b507a54eb 100644 > --- a/drivers/firmware/efi/libstub/tpm.c > +++ b/drivers/firmware/efi/libstub/tpm.c > @@ -114,8 +114,8 @@ void efi_retrieve_tpm2_eventlog(efi_system_table_t *sys_table_arg) > */ > last_entry_size = > __calc_tpm2_event_size((void *)last_entry_addr, > - (void *)log_location, > - false); > + (void *)(long)log_location, > + false); > } else { > last_entry_size = sizeof(struct tcpa_event) + > ((struct tcpa_event *) last_entry_addr)->event_size; > -- > 2.21.0.392.gf8f6787159e-goog - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)
Powered by blists - more mailing lists