linux-kernel - Re: [PATCH] psi: Clarify the units used in pressure files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <86482e87-c255-d4e6-9779-6cea2724dcea@redhat.com>
Date:   Wed, 3 Apr 2019 09:59:25 -0400
From:   Waiman Long <longman@...hat.com>
To:     Johannes Weiner <hannes@...xchg.org>
Cc:     Jonathan Corbet <corbet@....net>, linux-kernel@...r.kernel.org,
        linux-doc@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        "Peter Zijlstra (Intel)" <peterz@...radead.org>,
        Tejun Heo <tj@...nel.org>
Subject: Re: [PATCH] psi: Clarify the units used in pressure files

On 04/02/2019 05:18 PM, Johannes Weiner wrote:
> On Tue, Apr 02, 2019 at 03:38:10PM -0400, Waiman Long wrote:
>> The output of the PSI files show a bunch of numbers with no unit.
>> The psi.txt documentation file also does not indicate what units
>> are used.  One can only find out by looking at the source code. The
>> units are percentage for the averages and useconds for the total.
>> Make the information easier to find by documenting the units in psi.txt.
>>
>> Signed-off-by: Waiman Long <longman@...hat.com>
> Acked-by: Johannes Weiner <hannes@...xchg.org>
>
> Thanks Waiman!

I had thought about changing the message to show the units somehow, but
that may break existing applications that have dependency on the current
format. So documenting them in psi.txt is the best I can think of.

Cheers,
Longman