linux-kernel - Re: [PATCHv1] fpga: mgr: add FPGA configuration log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190403142022.GB5752@archbook>
Date:   Wed, 3 Apr 2019 07:20:22 -0700
From:   Moritz Fischer <mdf@...nel.org>
To:     richard.gong@...ux.intel.com
Cc:     atull@...nel.org, mdf@...nel.org, linux-fpga@...r.kernel.org,
        linux-kernel@...r.kernel.org, Richard Gong <richard.gong@...el.com>
Subject: Re: [PATCHv1] fpga: mgr: add FPGA configuration log

Hi Richard,

On Tue, Apr 02, 2019 at 05:25:43PM -0500, richard.gong@...ux.intel.com wrote:
> From: Richard Gong <richard.gong@...el.com>
> 
> Add a log for user to know FPGA configuration is successful
> 
> Signed-off-by: Richard Gong <richard.gong@...el.com>
> ---
>  drivers/fpga/fpga-mgr.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/fpga/fpga-mgr.c b/drivers/fpga/fpga-mgr.c
> index c386681..559e046 100644
> --- a/drivers/fpga/fpga-mgr.c
> +++ b/drivers/fpga/fpga-mgr.c
> @@ -151,6 +151,7 @@ static int fpga_mgr_write_complete(struct fpga_manager *mgr,
>  	}
>  	mgr->state = FPGA_MGR_STATE_OPERATING;
>  
> +	dev_info(&mgr->dev, "Successfully programming FPGA\n");

That info is available in FPGA manager's sysfs status entry, if at all
I'd make this a dev_dbg().

>From my end I don't see how we need this really.

Thanks,
Moritz