linux-kernel - Re: [PATCH v3] gcov: fix when CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190403152719.GH22763@bombadil.infradead.org>
Date:   Wed, 3 Apr 2019 08:27:19 -0700
From:   Matthew Wilcox <willy@...radead.org>
To:     trong@...roid.com
Cc:     oberpar@...ux.ibm.com, akpm@...ux-foundation.org,
        ndesaulniers@...gle.com, ghackmann@...roid.com, linux-mm@...ck.org,
        kbuild-all@...org, rdunlap@...radead.org, lkp@...el.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] gcov: fix when CONFIG_MODULES is not set

On Tue, Apr 02, 2019 at 10:09:56AM +0700, trong@...roid.com wrote:
> From: Tri Vo <trong@...roid.com>
> 
> Fixes: 8c3d220cb6b5 ("gcov: clang support")

I think this is the wrong fix.  Why not simply:

+++ b/include/linux/module.h
@@ -709,6 +709,11 @@ static inline bool is_module_text_address(unsigned long addr)
        return false;
 }
 
+static inline bool within_module(unsigned long addr, const struct module *mod)
+{
+       return false;
+}
+
 /* Get/put a kernel symbol (calls should be symmetric) */
 #define symbol_get(x) ({ extern typeof(x) x __attribute__((weak)); &(x); })
 #define symbol_put(x) do { } while (0)