linux-kernel - Re: [PATCH] platform/chrome: cros_ec_debugfs: Remove dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 3 Apr 2019 09:23:53 -0700
From:   Guenter Roeck <groeck@...gle.com>
To:     Enric Balletbo i Serra <enric.balletbo@...labora.com>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        Guenter Roeck <groeck@...omium.org>,
        Benson Leung <bleung@...omium.org>,
        Gwendal Grignou <gwendal@...omium.org>, kernel@...labora.com,
        Dmitry Torokhov <dtor@...omium.org>
Subject: Re: [PATCH] platform/chrome: cros_ec_debugfs: Remove dev_warn when
 console log is not supported

On Wed, Apr 3, 2019 at 6:47 AM Enric Balletbo i Serra
<enric.balletbo@...labora.com> wrote:
>
> If the debugfs interface is enabled, every time a CrOS device is
> instantiated a warning like this can appear for every probed device.
>
>  "device does not support reading the console log"
>
> The warning message adds nothing, rather it is source of confusion as
> this is expected on some cases. For example, on Samus, that has a
> cros-ec and a cros-pd instance the message appears twice, and I suspect
> this will happen also on those devices that has a non-standard EC.
>
> If the command is not supported just return silently and don't print the
> warning, otherwise the code will already print an error.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>

Reviewed-by: Guenter Roeck <groeck@...omium.org>

> ---
>
>  drivers/platform/chrome/cros_ec_debugfs.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/platform/chrome/cros_ec_debugfs.c b/drivers/platform/chrome/cros_ec_debugfs.c
> index 71308766e891..f0de1991b688 100644
> --- a/drivers/platform/chrome/cros_ec_debugfs.c
> +++ b/drivers/platform/chrome/cros_ec_debugfs.c
> @@ -306,11 +306,12 @@ static int cros_ec_create_console_log(struct cros_ec_debugfs *debug_info)
>         int read_params_size;
>         int read_response_size;
>
> -       if (!ec_read_version_supported(ec)) {
> -               dev_warn(ec->dev,
> -                       "device does not support reading the console log\n");
> +       /*
> +        * If the console log feature is not supported return silently and
> +        * don't create the console_log entry.
> +        */
> +       if (!ec_read_version_supported(ec))
>                 return 0;
> -       }
>
>         buf = devm_kzalloc(ec->dev, LOG_SIZE, GFP_KERNEL);
>         if (!buf)
> --
> 2.20.1
>