linux-kernel - Re: [PATCH][next] opa_vnic: fix check on record->event, incorrect operator used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 4 Apr 2019 08:32:13 -0300
From:   Jason Gunthorpe <jgg@...pe.ca>
To:     Dennis Dalessandro <dennis.dalessandro@...el.com>
Cc:     Colin King <colin.king@...onical.com>,
        Niranjana Vishwanathapura <niranjana.vishwanathapura@...el.com>,
        Doug Ledford <dledford@...hat.com>, linux-rdma@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] opa_vnic: fix check on record->event, incorrect
 operator used

On Thu, Apr 04, 2019 at 07:23:45AM -0400, Dennis Dalessandro wrote:
> On 4/4/2019 6:04 AM, Colin King wrote:
> > From: Colin Ian King <colin.king@...onical.com>
> > 
> > The check on record->event is always true because the wrong operator
> > is being used, used && instead of ||
> > 
> > Addresses-Coverity: ("Constant expression result")
> > Fixes: fae7a699a925 ("opa_vnic: Convert vport_idr to XArray")
> > Signed-off-by: Colin Ian King <colin.king@...onical.com>
> >   drivers/infiniband/ulp/opa_vnic/opa_vnic_vema.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/infiniband/ulp/opa_vnic/opa_vnic_vema.c b/drivers/infiniband/ulp/opa_vnic/opa_vnic_vema.c
> > index 76cd09410d9a..be5befd92d16 100644
> > +++ b/drivers/infiniband/ulp/opa_vnic/opa_vnic_vema.c
> > @@ -869,7 +869,7 @@ static void opa_vnic_event(struct ib_event_handler *handler,
> >   	      record->event, dev_name(&record->device->dev),
> >   	      record->element.port_num);
> > -	if (record->event != IB_EVENT_PORT_ERR ||
> > +	if (record->event != IB_EVENT_PORT_ERR &&
> >   	    record->event != IB_EVENT_PORT_ACTIVE)
> >   		return;
> > 
> 
> Missed this in code review. Thanks!
> 
> Acked-by: Dennis Dalessandro <dennis.dalessandro@...el.com>

Applied to for-next, thanks

Jason