linux-kernel - Re: [PATCH] mm/gup.c: fix the wrong comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 4 Apr 2019 06:32:20 -0600
From:   William Kucharski <william.kucharski@...cle.com>
To:     Huang Shijie <sjhuang@...vatar.ai>
Cc:     akpm@...ux-foundation.org, ira.weiny@...el.com,
        sfr@...b.auug.org.au, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/gup.c: fix the wrong comments



> On Apr 4, 2019, at 1:23 AM, Huang Shijie <sjhuang@...vatar.ai> wrote:
> 
> 
> + * This function is different from the get_user_pages_unlocked():
> + *      The @pages may has different page order with the result
> + *      got by get_user_pages_unlocked().
> + *

I suggest a slight rewrite of the comment, something like:

* Note this routine may fill the pages array with entries in a
* different order than get_user_pages_unlocked(), which may cause
* issues for callers expecting the routines to be equivalent.