linux-kernel - Re: [PATCH] staging: mt7621-pci-phy: prevent use of uninitialized variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 4 Apr 2019 14:55:56 +0200
From:   Sergio Paracuellos <sergio.paracuellos@...il.com>
To:     Antti Keränen <detegr@...il.com>
Cc:     Matthias Brugger <matthias.bgg@...il.com>,
        Greg KH <gregkh@...uxfoundation.org>,
        benniciemanuel78@...il.com, NeilBrown <neil@...wn.name>,
        devel@...verdev.osuosl.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: mt7621-pci-phy: prevent use of uninitialized variable

On Thu, Apr 4, 2019 at 2:46 PM Antti Keränen <detegr@...il.com> wrote:
>
> Do not use uninitialized variable 'port' when printing an error message
>
> Signed-off-by: Antti Keränen <detegr@...il.com>
> ---
>  drivers/staging/mt7621-pci-phy/pci-mt7621-phy.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/mt7621-pci-phy/pci-mt7621-phy.c b/drivers/staging/mt7621-pci-phy/pci-mt7621-phy.c
> index 118302c122ee..aa3ae7777632 100644
> --- a/drivers/staging/mt7621-pci-phy/pci-mt7621-phy.c
> +++ b/drivers/staging/mt7621-pci-phy/pci-mt7621-phy.c
> @@ -331,7 +331,7 @@ static int mt7621_pci_phy_probe(struct platform_device *pdev)
>
>         ret = of_address_to_resource(np, 0, &res);
>         if (ret) {
> -               dev_err(dev, "failed to get address resource(id-%d)\n", port);
> +               dev_err(dev, "failed to get address resource\n");
>                 return ret;
>         }

Reviewed-by: Sergio Paracuellos <sergio.paracuellos@...il.com>

Thanks,
     Sergio Paracuellos

>
> --
> 2.21.0
>