linux-kernel - Re: [PATCH 05/25] dt-bindings: leds: Add function and color properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 4 Apr 2019 15:21:52 +0200
From:   Pavel Machek <pavel@....cz>
To:     Rob Herring <robh@...nel.org>
Cc:     Jacek Anaszewski <jacek.anaszewski@...il.com>,
        Dan Murphy <dmurphy@...com>, linux-leds@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Baolin Wang <baolin.wang@...aro.org>,
        Daniel Mack <daniel@...que.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Oleh Kravchenko <oleg@....org.ua>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Simon Shields <simon@...eageos.org>
Subject: Re: [PATCH 05/25] dt-bindings: leds: Add function and color
 properties


> > > > > +- function: LED functon. Use one of the LED_FUNCTION_* prefixed
> > > > > definitions
> > > > > +        from the header include/dt-bindings/leds/common.h.
> > > > > +        If there is no matching LED_FUNCTION available, add a new one.
> > > > > +- color : Color of the LED. Use one of the LED_COLOR_NAME_*
> > > > > prefixed definitions
> > > > > +        from the header include/dt-bindings/leds/common.h.
> > > > > +        If there is no matching LED_COLOR_NAME available, add a
> > > > > new one.
> > > > > +
> > > > 
> > > > I am assuming multi color can re-use this property as well?
> > > 
> > > I intended it to be a string, but indeed it would be better if we will
> > > make it an integer to be consistent with the discussed LED multi color
> > > design.
> > 
> > Going further, I wonder if it would make sense to make function also
> > an integer. This way we could enforce use of LED functions known
> > to kernel.
> 
> I think if we did that, then we'd just need to keep label. I think we 
> need to allow for populating a string in DT matching a sticker next to 
> an LED on a device.

Well, there's often icon next to the LED... and we already use "label" for
something else. New property might make sense, but again, icons will make it tricky.

									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html