[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Thu, 4 Apr 2019 11:50:02 -0400 (EDT)
From: Pankaj Gupta <pagupta@...hat.com>
To: "Darrick J. Wong" <darrick.wong@...cle.com>
Cc: Jan Kara <jack@...e.cz>, kvm@...r.kernel.org, mst@...hat.com,
jasowang@...hat.com, Dave Chinner <david@...morbit.com>,
qemu-devel@...gnu.org, virtualization@...ts.linux-foundation.org,
adilger kernel <adilger.kernel@...ger.ca>, zwisler@...nel.org,
aarcange@...hat.com, dave jiang <dave.jiang@...el.com>,
linux-nvdimm@...ts.01.org,
vishal l verma <vishal.l.verma@...el.com>, david@...hat.com,
willy@...radead.org, hch@...radead.org, linux-acpi@...r.kernel.org,
jmoyer@...hat.com, linux-ext4@...r.kernel.org, lenb@...nel.org,
riel@...riel.com, stefanha@...hat.com,
dan j williams <dan.j.williams@...el.com>,
lcapitulino@...hat.com, kwolf@...hat.com, nilal@...hat.com,
tytso@....edu, xiaoguangrong eric <xiaoguangrong.eric@...il.com>,
cohuck@...hat.com, rjw@...ysocki.net, linux-kernel@...r.kernel.org,
linux-xfs@...r.kernel.org, linux-fsdevel@...r.kernel.org,
imammedo@...hat.com
Subject: Re: [Qemu-devel] [PATCH v4 5/5] xfs: disable map_sync for async
flush
> > >
> > > So I would put the helper in include/linux/dax.h and have it like:
> > >
> > > bool daxdev_mapping_supported(struct vm_area_struct *vma,
>
> Should this be static inline if you're putting it in the header file?
yes. Thanks.
>
> A comment ought to be added to describe what this predicate function
> does.
Sure, will add a comment describing the function.
>
> > > struct dax_device *dax_dev)
> > > {
> > > if (!(vma->vm_flags & VM_SYNC))
> > > return true;
> > > if (!IS_DAX(file_inode(vma->vm_file)))
> > > return false;
> > > return dax_synchronous(dax_dev);
> > > }
> >
> > Sure. This is much better. I was also not sure what to name the helper
> > function.
> > I will go ahead with this unless 'Dave' & 'Darrick' have anything to add.
>
> Jan's approach (modulo that one comment) looks good to me.
Sure. Thank you.
Best regards,
Pankaj
>
> --D
>
Powered by blists - more mailing lists