linux-kernel - Re: [PATCH net-next v3 4/4] net: phy: meson-gxl: clean-up gxl variant driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e043e430-362e-1d5e-af43-a95ec2bd27d2@gmail.com>
Date:   Thu, 4 Apr 2019 09:33:17 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Jerome Brunet <jbrunet@...libre.com>, Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Kevin Hilman <khilman@...libre.com>
Cc:     netdev@...r.kernel.org, linux-amlogic@...ts.infradead.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH net-next v3 4/4] net: phy: meson-gxl: clean-up gxl variant
 driver

On 4/4/19 6:11 AM, Jerome Brunet wrote:
> The purpose of this change is to align the gxl and g12a driver
> declaration.
> 
> Like on the g12a variant, remove genphy_aneg_done() from the driver
> declaration as the net phy framework will default to it anyway.
> 
> Also, the gxl phy id should be an exact match as well, so let's change
> this and use the macro provided.
> 
> Signed-off-by: Jerome Brunet <jbrunet@...libre.com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian