[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 4 Apr 2019 23:35:27 +0700
From: Linus Walleij <linus.walleij@...aro.org>
To: Chunfeng Yun <chunfeng.yun@...iatek.com>
Cc: Rob Herring <robh+dt@...nel.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
Mark Rutland <mark.rutland@....com>,
Matthias Brugger <matthias.bgg@...il.com>,
Adam Thomson <Adam.Thomson.Opensource@...semi.com>,
Li Jun <jun.li@....com>,
Badhri Jagan Sridharan <badhri@...gle.com>,
Hans de Goede <hdegoede@...hat.com>,
Andy Shevchenko <andy.shevchenko@...il.com>,
Min Guo <min.guo@...iatek.com>,
Alan Stern <stern@...land.harvard.edu>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
linux-usb@...r.kernel.org,
Linux ARM <linux-arm-kernel@...ts.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@...ts.infradead.org>
Subject: Re: [v3 PATCH 5/6] usb: roles: add USB Type-B GPIO connector driver
On Wed, Apr 3, 2019 at 9:09 AM Chunfeng Yun <chunfeng.yun@...iatek.com> wrote:
> Due to the requirement of usb-connector.txt binding, the old way
> using extcon to support USB Dual-Role switch is now deprecated
> when use Type-B connector.
> This patch introduces a driver of Type-B connector which typically
> uses an input GPIO to detect USB ID pin, and try to replace the
> function provided by extcon-usb-gpio driver
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@...iatek.com>
(...)
> +#include <linux/gpio.h>
If you need this include in a consumer, something is wrong. Just delete it,
> + info->id_gpiod = devm_gpiod_get_from_of_node(
> + dev, child, "id-gpios", 0, GPIOD_IN, "idpin");
This is OK if the child does not have any Linux device (struct platform_device
etc) created from it. Is this the case?
Yours,
Linus Walleij
Powered by blists - more mailing lists