linux-kernel - RE: [PATCH] mm/gup.c: fix the wrong comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 4 Apr 2019 16:53:53 +0000
From:   "Weiny, Ira" <ira.weiny@...el.com>
To:     William Kucharski <william.kucharski@...cle.com>,
        Huang Shijie <sjhuang@...vatar.ai>
CC:     "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "sfr@...b.auug.org.au" <sfr@...b.auug.org.au>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] mm/gup.c: fix the wrong comments

> > On Apr 4, 2019, at 1:23 AM, Huang Shijie <sjhuang@...vatar.ai> wrote:
> >
> >
> > + * This function is different from the get_user_pages_unlocked():
> > + *      The @pages may has different page order with the result
> > + *      got by get_user_pages_unlocked().
> > + *
> 
> I suggest a slight rewrite of the comment, something like:
> 
> * Note this routine may fill the pages array with entries in a
> * different order than get_user_pages_unlocked(), which may cause
> * issues for callers expecting the routines to be equivalent.

This is good too.  :-D

Ira