lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 4 Apr 2019 19:00:40 +0200 From: Sam Ravnborg <sam@...nborg.org> To: Joe Perches <joe@...ches.com> Cc: Guido Günther <agx@...xcpu.org>, Thierry Reding <thierry.reding@...il.com>, David Airlie <airlied@...ux.ie>, Daniel Vetter <daniel@...ll.ch>, Rob Herring <robh+dt@...nel.org>, Mark Rutland <mark.rutland@....com>, Kevin Hilman <khilman@...libre.com>, Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>, Shawn Guo <shawnguo@...nel.org>, Jagan Teki <jagan@...rulasolutions.com>, Martin Blumenstingl <martin.blumenstingl@...glemail.com>, Johan Hovold <johan@...nel.org>, "David S. Miller" <davem@...emloft.net>, Mauro Carvalho Chehab <mchehab+samsung@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Nicolas Ferre <nicolas.ferre@...rochip.com>, dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] drm/panel: Rocktech jh057n00900: Add terminating newlines to logging Hi Joe. On Thu, Apr 04, 2019 at 08:06:09AM -0700, Joe Perches wrote: > These were missing '\n' terminations, add them. > > Signed-off-by: Joe Perches <joe@...ches.com> > --- > drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c | 19 ++++++++++--------- > 1 file changed, 10 insertions(+), 9 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c b/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c > index 158a6d548068..d88ea8da2ec2 100644 > --- a/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c > +++ b/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c > @@ -123,7 +123,7 @@ static int jh057n_init_sequence(struct jh057n *ctx) > > ret = mipi_dsi_dcs_exit_sleep_mode(dsi); > if (ret < 0) { > - DRM_DEV_ERROR(dev, "Failed to exit sleep mode"); > + DRM_DEV_ERROR(dev, "Failed to exit sleep mode\n"); I was under the impression that newlines was optional these days. Should we always use them with logging? I did not find any obvious clues in linux/printk.h Sam
Powered by blists - more mailing lists