[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 4 Apr 2019 10:36:35 -0700
From: Guenter Roeck <groeck@...gle.com>
To: Nick Crews <ncrews@...omium.org>
Cc: Enric Balletbo i Serra <enric.balletbo@...labora.com>,
Benson Leung <bleung@...omium.org>, linux-leds@...r.kernel.org,
Jacek Anaszewski <jacek.anaszewski@...il.com>,
Pavel Machek <pavel@....cz>, alexandre.belloni@...tlin.com,
Alessandro Zummo <a.zummo@...ertech.it>,
linux-rtc@...r.kernel.org,
linux-kernel <linux-kernel@...r.kernel.org>,
Duncan Laurie <dlaurie@...omium.org>,
Simon Glass <sjg@...gle.com>, Dmitry Torokhov <dtor@...gle.com>
Subject: Re: [PATCH v5 3/3] platform/chrome: Standardize Chrome OS keyboard
backlight name
On Thu, Apr 4, 2019 at 10:11 AM Nick Crews <ncrews@...omium.org> wrote:
>
> We want all backlights for the system keyboard to
> use a common name, so the name "platform::kbd_backlight"
> would be better than the current "chromeos::kbd_backlight"
> name. Normally this wouldn't be worth changing, but the new
> Wilco keyboard backlight driver uses the "platform" name.
> We want to make it so all Chrome OS devices are consistent,
> so we'll change the name here too.
>
Wondering - who is the "we" you are talking about ?
Guenter
> The Power Manager daemon only looks for LEDs that match the
> pattern "*:kbd_backlight", so this change won't affect that.
>
> Signed-off-by: Nick Crews <ncrews@...omium.org>
> ---
> drivers/platform/chrome/cros_kbd_led_backlight.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/chrome/cros_kbd_led_backlight.c b/drivers/platform/chrome/cros_kbd_led_backlight.c
> index aa409f0201fb..c56c8405f39c 100644
> --- a/drivers/platform/chrome/cros_kbd_led_backlight.c
> +++ b/drivers/platform/chrome/cros_kbd_led_backlight.c
> @@ -77,7 +77,7 @@ static int keyboard_led_probe(struct platform_device *pdev)
> if (!cdev)
> return -ENOMEM;
>
> - cdev->name = "chromeos::kbd_backlight";
> + cdev->name = "platform::kbd_backlight";
> cdev->max_brightness = ACPI_KEYBOARD_BACKLIGHT_MAX;
> cdev->flags |= LED_CORE_SUSPENDRESUME;
> cdev->brightness_set = keyboard_led_set_brightness;
> --
> 2.20.1
>
Powered by blists - more mailing lists