linux-kernel - Re: [alsa-devel] [PATCH 1/3] soundwire: fix style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 4 Apr 2019 14:37:05 -0500
From:   Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To:     Joe Perches <joe@...ches.com>, alsa-devel@...a-project.org
Cc:     tiwai@...e.de, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org, liam.r.girdwood@...ux.intel.com,
        vkoul@...nel.org, broonie@...nel.org, jank@...ence.com,
        Sanyog Kale <sanyog.r.kale@...el.com>
Subject: Re: [alsa-devel] [PATCH 1/3] soundwire: fix style issues

Thanks for the review Joe,

@@ -458,13 +458,13 @@ static int sdw_assign_device_num(struct sdw_slave 
*slave)

>>   		mutex_unlock(&slave->bus->bus_lock);
>>   		if (dev_num < 0) {
>>   			dev_err(slave->bus->dev, "Get dev_num failed: %d",
>> -								dev_num);
>> +				dev_num);
> You could also add the missing terminating '\n' to these formats like:
>
>   			dev_err(slave->bus->dev, "Get dev_num failed: %d\n",
>
Yes indeed, I just fixed that tools reported, but that is a miss. Will 
fix with a v2 (hopefully with other comments).

-Pierre