linux-kernel - Re: [PATCH 3/6 v3] riscv: Fix syscall_get_arguments() and syscall_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 04 Apr 2019 16:29:42 -0700 (PDT)
From:   Palmer Dabbelt <palmer@...ive.com>
To:     rostedt@...dmis.org
CC:     ldv@...linux.org, linux-kernel@...r.kernel.org,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        mingo@...nel.org, akpm@...ux-foundation.org, luto@...capital.net,
        roland@...k.frob.com, oleg@...hat.com, linux-arch@...r.kernel.org,
        peterz@...radead.org, tglx@...utronix.de, gustavo@...eddedor.com,
        mingo@...hat.com, bp@...en8.de, hpa@...or.com, x86@...nel.org,
        linux@...inikbrodowski.net, luto@...nel.org, keescook@...omium.org,
        ebiederm@...ssion.com, wad@...omium.org, aou@...s.berkeley.edu,
        linux-riscv@...ts.infradead.org
Subject:     Re: [PATCH 3/6 v3] riscv: Fix syscall_get_arguments() and syscall_set_arguments()

On Thu, 04 Apr 2019 07:26:53 PDT (-0700), rostedt@...dmis.org wrote:
> On Thu, 4 Apr 2019 17:02:10 +0300
> "Dmitry V. Levin" <ldv@...linux.org> wrote:
>
>> On Mon, Apr 01, 2019 at 09:41:07AM -0400, Steven Rostedt wrote:
>> > From: "Dmitry V. Levin" <ldv@...linux.org>
>> >
>> > RISC-V syscall arguments are located in orig_a0,a1..a5 fields
>> > of struct pt_regs.
>> >
>> > Due to an off-by-one bug and a bug in pointer arithmetic
>> > syscall_get_arguments() was reading s3..s7 fields instead of a1..a5.
>> > Likewise, syscall_set_arguments() was writing s3..s7 fields
>> > instead of a1..a5.
>> >
>> > Link: http://lkml.kernel.org/r/20190329171221.GA32456@altlinux.org
>> >
>> > Fixes: e2c0cdfba7f69 ("RISC-V: User-facing API")
>> > Cc: Ingo Molnar <mingo@...hat.com>
>> > Cc: Kees Cook <keescook@...omium.org>
>> > Cc: Andy Lutomirski <luto@...capital.net>
>> > Cc: Will Drewry <wad@...omium.org>
>> > Cc: Palmer Dabbelt <palmer@...ive.com>
>> > Cc: Albert Ou <aou@...s.berkeley.edu>
>> > Cc: linux-riscv@...ts.infradead.org
>> > Cc: stable@...r.kernel.org # v4.15+
>> > Signed-off-by: Dmitry V. Levin <ldv@...linux.org>
>> > Signed-off-by: Steven Rostedt (VMware) <rostedt@...dmis.org>
>>
>> According to
>> https://lore.kernel.org/lkml/mhng-8e9b547b-7fe3-43d2-9dea-b217de923605@palmer-si-x1c4/
>> the following tag could be added to this patch:
>>
>> Acked-by: Palmer Dabbelt <palmer@...ive.com>
>
> That link isn't actually an ack. Palmer, you OK if I add it?

Acked-by: Palmer Dabbelt <palmer@...ive.com> (for the RISC-V parts)

Thanks!