linux-kernel - Re: [PATCH v4 net] ipv6: Fix dangling pointer when ipv6 fragment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 03 Apr 2019 21:43:14 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     hujunwei4@...wei.com
Cc:     kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        mingfangsen@...wei.com, liuzhiqiang26@...wei.com
Subject: Re: [PATCH v4 net] ipv6: Fix dangling pointer when ipv6 fragment

From: hujunwei <hujunwei4@...wei.com>
Date: Tue, 2 Apr 2019 19:38:04 +0800

> From: Junwei Hu <hujunwei4@...wei.com>
> 
> At the beginning of ip6_fragment func, the prevhdr pointer is
> obtained in the ip6_find_1stfragopt func.
> However, all the pointers pointing into skb header may change
> when calling skb_checksum_help func with
> skb->ip_summed = CHECKSUM_PARTIAL condition.
> The prevhdr pointe will be dangling if it is not reloaded after
> calling __skb_linearize func in skb_checksum_help func.
> 
> Here, I add a variable, nexthdr_offset, to evaluate the offset,
> which does not changes even after calling __skb_linearize func.
> 
> Fixes: 405c92f7a541 ("ipv6: add defensive check for CHECKSUM_PARTIAL skbs in ip_fragment")
> Signed-off-by: Junwei Hu <hujunwei4@...wei.com>
> Reported-by: Wenhao Zhang <zhangwenhao8@...wei.com>
> Reported-by: syzbot+e8ce541d095e486074fc@...kaller.appspotmail.com
> Reviewed-by: Zhiqiang Liu <liuzhiqiang26@...wei.com>
> Acked-by: Martin KaFai Lau <kafai@...com>
> ---
> V3->V4:
> - fix build warning

Applied and queued up for -stable.