linux-kernel - Re: [PATCH -next] ehea: Fix a copy-paste err in ehea_init_port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 4 Apr 2019 12:53:39 +0530
From:   Mukesh Ojha <mojha@...eaurora.org>
To:     Yue Haibing <yuehaibing@...wei.com>, davem@...emloft.net,
        dougmill@...ux.ibm.com
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH -next] ehea: Fix a copy-paste err in ehea_init_port_res


On 4/3/2019 1:17 PM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@...wei.com>
>
> pr->tx_bytes should be assigned to tx_bytes other than
> rx_bytes.
>
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Fixes: ce45b873028f ("ehea: Fixing statistics")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
Reviewed-by: Mukesh Ojha <mojha@...eaurora.org>

Cheers,
-Mukesh
> ---
>   drivers/net/ethernet/ibm/ehea/ehea_main.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/ibm/ehea/ehea_main.c b/drivers/net/ethernet/ibm/ehea/ehea_main.c
> index 90b62c1..707c8ba 100644
> --- a/drivers/net/ethernet/ibm/ehea/ehea_main.c
> +++ b/drivers/net/ethernet/ibm/ehea/ehea_main.c
> @@ -1463,7 +1463,7 @@ static int ehea_init_port_res(struct ehea_port *port, struct ehea_port_res *pr,
>   
>   	memset(pr, 0, sizeof(struct ehea_port_res));
>   
> -	pr->tx_bytes = rx_bytes;
> +	pr->tx_bytes = tx_bytes;
>   	pr->tx_packets = tx_packets;
>   	pr->rx_bytes = rx_bytes;
>   	pr->rx_packets = rx_packets;