linux-kernel - Re: [PATCH net] trival: net: skbuff: fix comment in skbuff.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5fb72714-5dc8-56da-1b50-a93949f0eb49@codeaurora.org>
Date:   Thu, 4 Apr 2019 13:05:54 +0530
From:   Mukesh Ojha <mojha@...eaurora.org>
To:     linmiaohe <linmiaohe@...wei.com>,
        David Miller <davem@...emloft.net>, willemb@...gle.com,
        fw@...len.de, edumazet@...gle.com, pabeni@...hat.com,
        pctammela@...il.com, deepa.kernel@...il.com, sbrivio@...hat.com,
        mirq-linux@...e.qmqm.pl, linux-kernel@...r.kernel.org
Cc:     Mingfangsen <mingfangsen@...wei.com>
Subject: Re: [PATCH net] trival: net: skbuff: fix comment in skbuff.h


On 4/3/2019 2:45 PM, linmiaohe wrote:
> From: Miaohe Lin <linmiaohe@...wei.com>
>
> It should be IPv6|UDP instead of IPv4|UDP for NETIF_F_IPV6_CSUM
>
> Signed-off-by: linmiaohe <linmiaohe@...wei.com>
Reviewed-by: Mukesh Ojha <mojha@...eaurora.org>

Cheers,
-Mukesh
> ---
>   include/linux/skbuff.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
> index 69b5538adcea..9683e00a5a79 100644
> --- a/include/linux/skbuff.h
> +++ b/include/linux/skbuff.h
> @@ -71,7 +71,7 @@
>    *     NETIF_F_IPV6_CSUM - Driver (device) is only able to checksum plain
>    *                       TCP or UDP packets over IPv6. These are specifically
>    *                       unencapsulated packets of the form IPv6|TCP or
> - *                       IPv4|UDP where the Next Header field in the IPv6
> + *                       IPv6|UDP where the Next Header field in the IPv6
>    *                       header is either TCP or UDP. IPv6 extension headers
>    *                       are not supported with this feature. This feature
>    *                       cannot be set in features for a device with