[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 4 Apr 2019 09:06:23 +0100
From: Lee Jones <lee.jones@...aro.org>
To: Matti Vaittinen <matti.vaittinen@...rohmeurope.com>
Cc: "alexandre.belloni@...tlin.com" <alexandre.belloni@...tlin.com>,
"robh+dt@...nel.org" <robh+dt@...nel.org>,
"mazziesaccount@...il.com" <mazziesaccount@...il.com>,
"mturquette@...libre.com" <mturquette@...libre.com>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
"sre@...nel.org" <sre@...nel.org>,
"linus.walleij@...aro.org" <linus.walleij@...aro.org>,
"sboyd@...nel.org" <sboyd@...nel.org>,
"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
"a.zummo@...ertech.it" <a.zummo@...ertech.it>,
"broonie@...nel.org" <broonie@...nel.org>,
"Mutanen, Mikko" <Mikko.Mutanen@...rohmeurope.com>,
"mark.rutland@....com" <mark.rutland@....com>,
"linux-watchdog@...r.kernel.org" <linux-watchdog@...r.kernel.org>,
"linux@...ck-us.net" <linux@...ck-us.net>,
"lgirdwood@...il.com" <lgirdwood@...il.com>,
"bgolaszewski@...libre.com" <bgolaszewski@...libre.com>,
"wim@...ux-watchdog.org" <wim@...ux-watchdog.org>,
"linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
"linux-rtc@...r.kernel.org" <linux-rtc@...r.kernel.org>,
"Haikola, Heikki" <Heikki.Haikola@...rohmeurope.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v11 2/8] mfd: bd70528: Support ROHM bd70528 PMIC - core
> > > ROHM. Also, I am not terribly excited about the option of changing this
> > > back to function-pointer as I already removed the pointer from parent
> > > data and this changed parent data is already adapted to all sub drivers
> > > - so this is all just babbling. Maybe it is just my huge ego shouting
> > > there - 'I was right, I must have the final say'.
> >
> > No, a call-back function would be a back-step.
>
> You are probably right.
>
> > Ego or no ego, you're wrong. =:-D
>
> I'd rephrase that as "It's not that I am wrong, but you are right." =)
Works for me.
> > > As a side note, I already did submit v12 with other styling fixes but
> > > which left the WDT function in MFD. If you still see the WDT functions
> > > should be exported from WDT - then please ignore the v12. I'll do v13
> > > at the afternoon (my time, which is only a bit after noon your time I
> > > guess) which will export these functions from WDT. (Well, I had to try
> > > once more :D)
> >
> > Please keep the WDT code in the WDT driver. Create a little stub for
> > the cases where the WDT driver is not enabled - job done.
>
> Yes Sir.
=;-)
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
Powered by blists - more mailing lists