linux-kernel - Re: [PATCH AUTOSEL 5.0 209/262] regulator: mcp16502: Include linux/gpio/consumer.h to fix build error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190404004608.GG16241@sasha-vm>
Date:   Wed, 3 Apr 2019 20:46:08 -0400
From:   Sasha Levin <sashal@...nel.org>
To:     Mark Brown <broonie@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Axel Lin <axel.lin@...ics.com>
Subject: Re: [PATCH AUTOSEL 5.0 209/262] regulator: mcp16502: Include
 linux/gpio/consumer.h to fix build error

On Wed, Mar 27, 2019 at 07:32:11PM +0000, Mark Brown wrote:
>On Wed, Mar 27, 2019 at 02:01:04PM -0400, Sasha Levin wrote:
>> From: Axel Lin <axel.lin@...ics.com>
>>
>> [ Upstream commit f3c6a1a194317f3a31ee2b2067bb0a41de64bc8b ]
>>
>> Fix below build error:
>> drivers/regulator/mcp16502.c: In function ‘mcp16502_gpio_set_mode’:
>> drivers/regulator/mcp16502.c:135:3: error: implicit declaration of function ‘gpiod_set_value’; did you mean ‘gpio_set_value’? [-Werror=implicit-function-declaration]
>>    gpiod_set_value(mcp->lpm, 0);
>
>Does this error actually manifest in v5.0?

I couldn't reproduce the error on f3c6a1a194317f^ so I assumed it
requires a specialized config.

--
Thanks,
Sasha