lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <DB3PR0402MB3916E8CFA62672094C7DC020F5500@DB3PR0402MB3916.eurprd04.prod.outlook.com> Date: Thu, 4 Apr 2019 01:29:48 +0000 From: Anson Huang <anson.huang@....com> To: "dmitry.torokhov@...il.com" <dmitry.torokhov@...il.com> CC: "shawnguo@...nel.org" <shawnguo@...nel.org>, "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>, "kernel@...gutronix.de" <kernel@...gutronix.de>, "festevam@...il.com" <festevam@...il.com>, "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, dl-linux-imx <linux-imx@....com> Subject: RE: [PATCH 1/2] input: keyboard: imx: no need to control interrupt status in event check Hi, Dmitry Best Regards! Anson Huang > -----Original Message----- > From: dmitry.torokhov@...il.com [mailto:dmitry.torokhov@...il.com] > Sent: 2019年4月4日 5:49 > To: Anson Huang <anson.huang@....com> > Cc: shawnguo@...nel.org; s.hauer@...gutronix.de; > kernel@...gutronix.de; festevam@...il.com; linux-input@...r.kernel.org; > linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org; dl-linux- > imx <linux-imx@....com> > Subject: Re: [PATCH 1/2] input: keyboard: imx: no need to control interrupt > status in event check > > Hi Anson, > > On Fri, Mar 29, 2019 at 07:00:43AM +0000, Anson Huang wrote: > > There is no need to enable release interrupt and disable depress > > interrupt in event check, as a timer is setup for checking these > > events rather than interrupts. > > But won't using release interrupt allow signalling key release earlier? It makes sense, patch #1 can be dropped, I will resend the patch #2 for review. Thanks, Anson. > > > > > Signed-off-by: Anson Huang <Anson.Huang@....com> > > --- > > drivers/input/keyboard/imx_keypad.c | 5 ----- > > 1 file changed, 5 deletions(-) > > > > diff --git a/drivers/input/keyboard/imx_keypad.c > > b/drivers/input/keyboard/imx_keypad.c > > index 539cb67..7e32c36 100644 > > --- a/drivers/input/keyboard/imx_keypad.c > > +++ b/drivers/input/keyboard/imx_keypad.c > > @@ -276,11 +276,6 @@ static void imx_keypad_check_for_events(struct > timer_list *t) > > reg_val = readw(keypad->mmio_base + KPSR); > > reg_val |= KBD_STAT_KPKR | KBD_STAT_KRSS; > > writew(reg_val, keypad->mmio_base + KPSR); > > - > > - reg_val = readw(keypad->mmio_base + KPSR); > > - reg_val |= KBD_STAT_KRIE; > > - reg_val &= ~KBD_STAT_KDIE; > > - writew(reg_val, keypad->mmio_base + KPSR); > > } > > } > > > > -- > > 2.7.4 > > > > Thanks. > > -- > Dmitry
Powered by blists - more mailing lists