lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20190404.173240.1338878948110207179.davem@davemloft.net> Date: Thu, 04 Apr 2019 17:32:40 -0700 (PDT) From: David Miller <davem@...emloft.net> To: ms@....tdt.de Cc: andrew.hendry@...il.com, khc@...waw.pl, isdn@...ux-pingi.de, edumazet@...gle.com, linux-x25@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 2/4] wan/hdlc_x25: fix skb handling From: Martin Schiller <ms@....tdt.de> Date: Wed, 3 Apr 2019 07:01:16 +0200 > /* X.25 to LAPB */ > switch (skb->data[0]) { > case X25_IFACE_DATA: /* Data to be transmitted */ > - skb_pull(skb, 1); > - if ((result = lapb_data_request(dev, skb)) != LAPB_OK) > - dev_kfree_skb(skb); > - return NETDEV_TX_OK; > + skbn = skb_copy(skb, GFP_ATOMIC); > + skb_pull(skbn, 1); > + skb_reset_network_header(skbn); > + if ((result = lapb_data_request(dev, skbn)) != LAPB_OK) > + dev_kfree_skb(skbn); This leaks 'skb'. No way I'm applying this stuff.
Powered by blists - more mailing lists