linux-kernel - Re: [PATCH] stm class: Fix channel free in stm output free path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 5 Apr 2019 11:32:55 +0100
From:   Suzuki K Poulose <suzuki.poulose@....com>
To:     saiprakash.ranjan@...eaurora.org,
        alexander.shishkin@...ux.intel.com, gregkh@...uxfoundation.org,
        mcoquelin.stm32@...il.com, alexandre.torgue@...com,
        linux-stm32@...md-mailman.stormreply.com,
        mathieu.poirier@...aro.org, mike.leach@...aro.org,
        leo.yan@...aro.org
Cc:     rnayak@...eaurora.org, vivek.gautam@...eaurora.org,
        sibis@...eaurora.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        tingwei@...eaurora.org, stable@...r.kernel.org
Subject: Re: [PATCH] stm class: Fix channel free in stm output free path



On 05/04/2019 11:24, Sai Prakash Ranjan wrote:
> From: Tingwei Zhang <tingwei@...eaurora.org>
> 
> Number of free masters is not set correctly in stm
> free path. Fix this by properly adding the number
> of output channels before setting them to 0 in
> stm_output_disclaim().
> 
> Currently it is equivalent to doing nothing since
> master->nr_free is incremented by 0.
> 
> Fixes: 7bd1d4093c2f ("stm class: Introduce an abstraction for System Trace Module devices")
> Signed-off-by: Tingwei Zhang <tingwei@...eaurora.org>
> Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@...eaurora.org>
> Cc: stable@...r.kernel.org
> ---
>   drivers/hwtracing/stm/core.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwtracing/stm/core.c b/drivers/hwtracing/stm/core.c
> index c7ba8acfd4d5..5b5807cbcf7c 100644
> --- a/drivers/hwtracing/stm/core.c
> +++ b/drivers/hwtracing/stm/core.c
> @@ -218,8 +218,8 @@ stm_output_disclaim(struct stm_device *stm, struct stm_output *output)
>   	bitmap_release_region(&master->chan_map[0], output->channel,
>   			      ilog2(output->nr_chans));
>   
> -	output->nr_chans = 0;
>   	master->nr_free += output->nr_chans;
> +	output->nr_chans = 0;

Reviewed-by: Suzuki K Poulose <suzuki.poulose@....com>