[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <0e7d2e00050cca6ffd05b8d85af33be99aaad10c.camel@suse.de>
Date: Fri, 05 Apr 2019 14:22:09 +0200
From: Nicolas Saenz Julienne <nsaenzjulienne@...e.de>
To: Dan Carpenter <dan.carpenter@...cle.com>
Cc: linux-kernel@...r.kernel.org, stefan.wahren@...e.com,
devel@...verdev.osuosl.org,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
phil@...pberrypi.org, eric@...olt.net,
linux-rpi-kernel@...ts.infradead.org,
linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/3] Revert "staging: vchiq_2835_arm: quit using custom
down_interruptible()"
On Fri, 2019-04-05 at 15:02 +0300, Dan Carpenter wrote:
> On Fri, Apr 05, 2019 at 01:34:20PM +0200, Nicolas Saenz Julienne wrote:
> > This reverts commit ff5979ad86368425b7da3a25f4e84650b51ff5fd.
> > ---
>
> Git kind of sets you up for failure with reverts...
>
> Fix the subject, add a commit message and a Signed off by etc. We need
> all the regular stuff. See commit 75ae193626de ("dm: revert
> 8f50e358153d ("dm: limit the max bio size as BIO_MAX_PAGES *
> PAGE_SIZE")") for an example of how to do it nicely.
>
Will do, Thanks!
> regards,
> dan carpenter
>
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists