linux-kernel - Re: [RFC PATCH] drm/i915: Don't panic on non-empty list of free cachelines

Open Source and information security mailing list archives

Message-ID: <2790d298adb0d57a67a0a3c9bc9aa8c7c08f0a0d.camel@linux.intel.com>
Date:   Fri, 05 Apr 2019 14:42:16 +0200
From:   Janusz Krzysztofik <janusz.krzysztofik@...ux.intel.com>
To:     Chris Wilson <chris@...is-wilson.co.uk>,
        Jani Nikula <jani.nikula@...ux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@...el.com>
Cc:     David Airlie <airlied@...ux.ie>, intel-gfx@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        michal.wajdeczko@...el.com
Subject: Re: [RFC PATCH] drm/i915: Don't panic on non-empty list of free
 cachelines

On Fri, 2019-04-05 at 13:20 +0100, Chris Wilson wrote:
> Quoting Janusz Krzysztofik (2019-04-05 13:13:31)
> > From: Janusz Krzysztofik <janusz.krzysztofik@...el.com>
> > 
> > If there are active users of a device during driver unbind, the
> > driver
> > now panics on non-empty list of free cachelines.
> 
> This panic is there to say that fini is being called with active
> contexts, that it is being called too early. Those requests should be
> cleaned up first, unpinning the contexts and resources, and so
> letting
> the timeline be freed.

OK, I see.  But why panic?  Maybe a WARN() would be enough.

Thanks,
Janusz

> -Chris
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives