linux-kernel - [tip:irq/urgent] irqchip/irq-ls1x: Missing error code in ls1x_intc_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 5 Apr 2019 05:43:11 -0700
From:   tip-bot for Dan Carpenter <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     tglx@...utronix.de, mojha@...eaurora.org, jason@...edaemon.net,
        marc.zyngier@....com, dan.carpenter@...cle.com, hpa@...or.com,
        mingo@...nel.org, jiaxun.yang@...goat.com,
        linux-kernel@...r.kernel.org
Subject: [tip:irq/urgent] irqchip/irq-ls1x: Missing error code in
 ls1x_intc_of_init()

Commit-ID:  95c5c618fa4349b2ba13aebeabf71911208dfc5e
Gitweb:     https://git.kernel.org/tip/95c5c618fa4349b2ba13aebeabf71911208dfc5e
Author:     Dan Carpenter <dan.carpenter@...cle.com>
AuthorDate: Fri, 29 Mar 2019 09:21:37 +0300
Committer:  Thomas Gleixner <tglx@...utronix.de>
CommitDate: Fri, 5 Apr 2019 14:37:56 +0200

irqchip/irq-ls1x: Missing error code in ls1x_intc_of_init()

Currently, when irq_domain_add_linear() fails, the error code does not get
set so it returns zero which is wrong.  Fix it by setting the appropriate
error code.

Fixes: 9e543e22e204 ("irqchip: Add driver for Loongson-1 interrupt controller")
Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
Reviewed-by: Mukesh Ojha <mojha@...eaurora.org>
Cc: Marc Zyngier <marc.zyngier@....com>
Cc: Jiaxun Yang <jiaxun.yang@...goat.com>
Cc: Jason Cooper <jason@...edaemon.net>
Cc: kernel-janitors@...r.kernel.org
Link: https://lkml.kernel.org/r/20190329062136.GQ32613@kadam

---
 drivers/irqchip/irq-ls1x.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/irqchip/irq-ls1x.c b/drivers/irqchip/irq-ls1x.c
index 86b72fbd3b45..353111a10413 100644
--- a/drivers/irqchip/irq-ls1x.c
+++ b/drivers/irqchip/irq-ls1x.c
@@ -130,6 +130,7 @@ static int __init ls1x_intc_of_init(struct device_node *node,
 					     NULL);
 	if (!priv->domain) {
 		pr_err("ls1x-irq: cannot add IRQ domain\n");
+		err = -ENOMEM;
 		goto out_iounmap;
 	}