linux-kernel - Re: [PATCH] power: charger-manager: fix a potential NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190405140031.6u35e5jd56aqms6o@earth.universe>
Date:   Fri, 5 Apr 2019 16:00:31 +0200
From:   Sebastian Reichel <sre@...nel.org>
To:     Kangjie Lu <kjlu@....edu>
Cc:     pakki001@....edu, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] power: charger-manager: fix a potential NULL pointer
 dereference

Hi,

On Thu, Mar 14, 2019 at 01:02:47AM -0500, Kangjie Lu wrote:
> In case create_freezable_workqueue fails, the fix return -ENOMEM
> to avoid a potential NULL pointer dereference.
> 
> Signed-off-by: Kangjie Lu <kjlu@....edu>
> ---

Thanks, queued.

-- Sebastian

>  drivers/power/supply/charger-manager.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/power/supply/charger-manager.c b/drivers/power/supply/charger-manager.c
> index 38be91f21cc4..d29c4f338157 100644
> --- a/drivers/power/supply/charger-manager.c
> +++ b/drivers/power/supply/charger-manager.c
> @@ -1987,6 +1987,9 @@ static struct platform_driver charger_manager_driver = {
>  static int __init charger_manager_init(void)
>  {
>  	cm_wq = create_freezable_workqueue("charger_manager");
> +	if (unlikely(!cm_wq))
> +		return -ENOMEM;
> +
>  	INIT_DELAYED_WORK(&cm_monitor_work, cm_monitor_poller);
>  
>  	return platform_driver_register(&charger_manager_driver);
> -- 
> 2.17.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)