linux-kernel - Re: [PATCH net-next] rxrpc: Mark expected switch fall-through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <19488.1554477352@warthog.procyon.org.uk>
Date:   Fri, 05 Apr 2019 16:15:52 +0100
From:   David Howells <dhowells@...hat.com>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc:     dhowells@...hat.com, "David S. Miller" <davem@...emloft.net>,
        linux-afs@...ts.infradead.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Kees Cook <keescook@...omium.org>
Subject: Re: [PATCH net-next] rxrpc: Mark expected switch fall-through

Gustavo A. R. Silva <gustavo@...eddedor.com> wrote:

>  		/* Fall through and set IPv4 options too otherwise we don't get
>  		 * errors from IPv4 packets sent through the IPv6 socket.
>  		 */
> -
> +		/* Fall through */

Er, no.  Please (a) don't remove the blank line that's providing visual
separation and (b) observe that the previous comment already says "Fall
through" right at the beginning, so NAK.

If the compiler doesn't recognise this, then fix the compiler please.

David